vdk-core: BaseVdkError exception propagation flaw fix #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue, where a particular exceptions were not propagating to the respective except(catch) clauses. The process was suddenly blindly exiting with code 1. Did troubleshoot the flaw to vdk-core's error framework, where BaseVdkError was extending ClickException without any purpose known/documented. That was causing all the BaseVdkError-based DomainErrors like VdkConfigurationError, UserCodeError, PlatformServiceError, and so on, to stop propagating to handlers. Did fix the errors framework design flaw. Testing Done: added the vdk_exception exit code test coverage, that relies on proper exception propagation and handling; ci/cd Signed-off-by: ikoleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue, where a particular exceptions were not propagating
to the respective except(catch) clauses. The process was suddenly
blindly exiting with code 1.
Did troubleshoot the flaw to vdk-core's error framework, where
BaseVdkError was extending ClickException without any purpose
known/documented.
That was causing all the BaseVdkError-based DomainErrors like
VdkConfigurationError, UserCodeError, PlatformServiceError, and so on,
to stop propagating to handlers. Did fix the errors framework design
flaw.
Testing Done: added the vdk_exception exit code test coverage,
that relies on proper exception propagation and handling; ci/cd
Signed-off-by: ikoleva [email protected]